Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress indicator to SCM in activity bar while QuickDiff is preparing #136969

Merged
merged 1 commit into from Nov 12, 2021
Merged

Add progress indicator to SCM in activity bar while QuickDiff is preparing #136969

merged 1 commit into from Nov 12, 2021

Conversation

gjsjohnmurray
Copy link
Contributor

This PR closes #136968

@bpasero are you willing to review this?

@bpasero
Copy link
Member

bpasero commented Nov 11, 2021

Rather @joaomoreno

@joaomoreno joaomoreno assigned lszomoru and unassigned joaomoreno Nov 12, 2021
@joaomoreno joaomoreno self-requested a review November 12, 2021 13:53
joaomoreno
joaomoreno approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bpasero, rather @lszomoru.

But I like it!

@lszomoru
Copy link
Member

Thanks @gjsjohnmurray! Will take a look at this later today!

@lszomoru lszomoru added git GIT issues scm General SCM compound issues and removed git GIT issues labels Nov 12, 2021
@lszomoru lszomoru added this to the November 2021 milestone Nov 12, 2021
@lszomoru
Copy link
Member

LGTM!

@lszomoru lszomoru merged commit 5f4830b into microsoft:main Nov 12, 2021
@gjsjohnmurray gjsjohnmurray deleted the dirtyDiffDecorator-progress branch November 12, 2021 14:53
@lszomoru lszomoru mentioned this pull request Nov 25, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@lszomoru lszomoru

Labels
scm General SCM compound issues
Projects
None yet
Milestone
November 2021
Development

Successfully merging this pull request may close these issues.

Add a progress indicator to SCM icon in activity bar when QuickDiff is being prepared
4 participants
@gjsjohnmurray @bpasero @lszomoru @joaomoreno