add NotebookFilter and make it a real thing
#144826
Conversation
|
Ready for review/fyi but some doc polish is still needed |
| @@ -2056,6 +2079,9 @@ declare module 'vscode' { | |||
| * | |||
| * @example <caption>A language filter that applies to all package.json paths</caption> | |||
| * { language: 'json', pattern: '**/package.json' } | |||
| * | |||
| * @example <caption>A language filter that applies to all python files on jupyter notebooks</caption> | |||
| * { language: 'python', notebook: 'jupyter-notebook' } | |||
| */ | |||
| export interface DocumentFilter { | |||
There was a problem hiding this comment.
I'm still confused on how DocumentFilter interacts with NotebookFilter. I'd sort of expect the new type to be DocumentFilter | NotebookFilter instead of adding DocumentFilter.notebook property
Are there use cases where I need to set different properties on an outer DocumentFilter than are set on the inner NotebookFilter?
There was a problem hiding this comment.
In LSP I did DocumentFilter = TextDocumentFilter | NotebookDocumentFilter where the old DocumentFilter = TextDocumentFilter.
There was a problem hiding this comment.
Actually the above statement is incorrect :-).
What we actually want to support is the following: register a hover provider for cell's inside a notebook where the cell's language is python the notebook document itself is of type jupyter-notebook and the notebook is stored on disk (e.g. it's scheme is file).
There was a problem hiding this comment.
In LSP I have the following definition
DocumentFilter | { language?: string; notebook?: string | NotebookFilter }
This PR refines #141143 and adds the ability to match not just notebookType but also notebook scheme and pattern.
fyi @dbaeumer