From f3acc10fcfded1b833c4c409179e2edb4c0daf78 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joaqu=C3=ADn=20Ruales?= <1588988+jruales@users.noreply.github.com> Date: Wed, 16 Mar 2022 15:18:02 -0700 Subject: [PATCH 1/4] Update extHostApiCommands.ts --- src/vs/workbench/api/common/extHostApiCommands.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/api/common/extHostApiCommands.ts b/src/vs/workbench/api/common/extHostApiCommands.ts index 4b866a477f30b..df0bab6b60435 100644 --- a/src/vs/workbench/api/common/extHostApiCommands.ts +++ b/src/vs/workbench/api/common/extHostApiCommands.ts @@ -394,7 +394,7 @@ const newCommands: ApiCommand[] = [ 'vscode.openWith', '_workbench.openWith', 'Opens the provided resource with a specific editor.', [ ApiCommandArgument.Uri.with('resource', 'Resource to open'), - ApiCommandArgument.String.with('viewId', 'Custom editor view id or \'default\' to use VS Code\'s default editor'), + ApiCommandArgument.String.with('viewId', 'Custom editor view id. This should match the viewType from the customEditors contribution point. Use \'default\' to use VS Code\'s default editor'), new ApiCommandArgument('columnOrOptions', 'Either the column in which to open or editor options, see vscode.TextDocumentShowOptions', v => v === undefined || typeof v === 'number' || typeof v === 'object', v => !v ? v : typeof v === 'number' ? [typeConverters.ViewColumn.from(v), undefined] : [typeConverters.ViewColumn.from(v.viewColumn), typeConverters.TextEditorOpenOptions.from(v)], From 96768670bbe2d4e85eb997cfdd3cdd9ba30dde4e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joaqu=C3=ADn=20Ruales?= <1588988+jruales@users.noreply.github.com> Date: Thu, 17 Mar 2022 13:16:06 -0700 Subject: [PATCH 2/4] Update extHostApiCommands.ts --- src/vs/workbench/api/common/extHostApiCommands.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/api/common/extHostApiCommands.ts b/src/vs/workbench/api/common/extHostApiCommands.ts index df0bab6b60435..e90b9e59b0280 100644 --- a/src/vs/workbench/api/common/extHostApiCommands.ts +++ b/src/vs/workbench/api/common/extHostApiCommands.ts @@ -394,7 +394,7 @@ const newCommands: ApiCommand[] = [ 'vscode.openWith', '_workbench.openWith', 'Opens the provided resource with a specific editor.', [ ApiCommandArgument.Uri.with('resource', 'Resource to open'), - ApiCommandArgument.String.with('viewId', 'Custom editor view id. This should match the viewType from the customEditors contribution point. Use \'default\' to use VS Code\'s default editor'), + ApiCommandArgument.String.with('viewId', 'Custom editor view id. This should be the viewType for custom editors or the notebookType for custom notebooks. Use \'default\' to use VS Code\'s default text editor'), new ApiCommandArgument('columnOrOptions', 'Either the column in which to open or editor options, see vscode.TextDocumentShowOptions', v => v === undefined || typeof v === 'number' || typeof v === 'object', v => !v ? v : typeof v === 'number' ? [typeConverters.ViewColumn.from(v), undefined] : [typeConverters.ViewColumn.from(v.viewColumn), typeConverters.TextEditorOpenOptions.from(v)], From 1d98b06061beaadac5662bf7dd9bb49ecef62087 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joaqu=C3=ADn=20Ruales?= <1588988+jruales@users.noreply.github.com> Date: Thu, 17 Mar 2022 13:17:33 -0700 Subject: [PATCH 3/4] Update extHostApiCommands.ts --- src/vs/workbench/api/common/extHostApiCommands.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/api/common/extHostApiCommands.ts b/src/vs/workbench/api/common/extHostApiCommands.ts index e90b9e59b0280..48915fdaf0818 100644 --- a/src/vs/workbench/api/common/extHostApiCommands.ts +++ b/src/vs/workbench/api/common/extHostApiCommands.ts @@ -394,7 +394,7 @@ const newCommands: ApiCommand[] = [ 'vscode.openWith', '_workbench.openWith', 'Opens the provided resource with a specific editor.', [ ApiCommandArgument.Uri.with('resource', 'Resource to open'), - ApiCommandArgument.String.with('viewId', 'Custom editor view id. This should be the viewType for custom editors or the notebookType for custom notebooks. Use \'default\' to use VS Code\'s default text editor'), + ApiCommandArgument.String.with('viewId', 'Custom editor view id. This should be the viewType string for custom editors or the notebookType string for custom notebooks. Use \'default\' to use VS Code\'s default text editor'), new ApiCommandArgument('columnOrOptions', 'Either the column in which to open or editor options, see vscode.TextDocumentShowOptions', v => v === undefined || typeof v === 'number' || typeof v === 'object', v => !v ? v : typeof v === 'number' ? [typeConverters.ViewColumn.from(v), undefined] : [typeConverters.ViewColumn.from(v.viewColumn), typeConverters.TextEditorOpenOptions.from(v)], From 9981b148fe4ae381ad70dfc812bb32133bfc8ba8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Joaqu=C3=ADn=20Ruales?= <1588988+jruales@users.noreply.github.com> Date: Thu, 17 Mar 2022 13:18:11 -0700 Subject: [PATCH 4/4] Update extHostApiCommands.ts --- src/vs/workbench/api/common/extHostApiCommands.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/api/common/extHostApiCommands.ts b/src/vs/workbench/api/common/extHostApiCommands.ts index 48915fdaf0818..0db76b4d218bf 100644 --- a/src/vs/workbench/api/common/extHostApiCommands.ts +++ b/src/vs/workbench/api/common/extHostApiCommands.ts @@ -394,7 +394,7 @@ const newCommands: ApiCommand[] = [ 'vscode.openWith', '_workbench.openWith', 'Opens the provided resource with a specific editor.', [ ApiCommandArgument.Uri.with('resource', 'Resource to open'), - ApiCommandArgument.String.with('viewId', 'Custom editor view id. This should be the viewType string for custom editors or the notebookType string for custom notebooks. Use \'default\' to use VS Code\'s default text editor'), + ApiCommandArgument.String.with('viewId', 'Custom editor view id. This should be the viewType string for custom editors or the notebookType string for notebooks. Use \'default\' to use VS Code\'s default text editor'), new ApiCommandArgument('columnOrOptions', 'Either the column in which to open or editor options, see vscode.TextDocumentShowOptions', v => v === undefined || typeof v === 'number' || typeof v === 'object', v => !v ? v : typeof v === 'number' ? [typeConverters.ViewColumn.from(v), undefined] : [typeConverters.ViewColumn.from(v.viewColumn), typeConverters.TextEditorOpenOptions.from(v)],