Skip to content

Update coverage folder location #145597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Conversation

Charles-Gagnon
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon commented Mar 21, 2022

The coverage folder isn't generated at the root of the workspace, it's put in the .build folder currently.

Fixes #145607

The coverage folder isn't generated at the root of the workspace, it's put in the `.build` folder currently.
@weinand
Copy link
Contributor

weinand commented Mar 21, 2022

What is the original issue that you want to fix with this PR?

@Charles-Gagnon
Copy link
Contributor Author

The indicated location is wrong - the coverage folder isn't generated at the root of the repo. It's in the .build folder instead. Just updating the docs to be correct for anyone trying to run the tests with coverage.

@weinand
Copy link
Contributor

weinand commented Mar 21, 2022

please create an issue first.

@Charles-Gagnon
Copy link
Contributor Author

Done #145607

@weinand weinand assigned bpasero and unassigned weinand Mar 21, 2022
@bpasero bpasero assigned alexdima and unassigned bpasero Mar 22, 2022
@alexdima alexdima added this to the March 2022 milestone Mar 22, 2022
@alexdima alexdima merged commit 9c5d758 into microsoft:main Mar 22, 2022
@alexdima
Copy link
Member

Thank you!

@Charles-Gagnon Charles-Gagnon deleted the patch-1 branch March 22, 2022 16:21
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test README has wrong location for coverage folder
4 participants