From 9e7a49624c57ac38a3ca1386c441e108ca99dc81 Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Fri, 5 Aug 2022 08:44:00 +0200 Subject: [PATCH 1/2] sandbox - log if sandboxed in telemetry --- .../telemetry/electron-sandbox/workbenchCommonProperties.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/vs/workbench/services/telemetry/electron-sandbox/workbenchCommonProperties.ts b/src/vs/workbench/services/telemetry/electron-sandbox/workbenchCommonProperties.ts index 83f9b2c2a7b7f..67aac3de104df 100644 --- a/src/vs/workbench/services/telemetry/electron-sandbox/workbenchCommonProperties.ts +++ b/src/vs/workbench/services/telemetry/electron-sandbox/workbenchCommonProperties.ts @@ -38,6 +38,8 @@ export async function resolveWorkbenchCommonProperties( result['common.isNewSession'] = !lastSessionDate ? '1' : '0'; // __GDPR__COMMON__ "common.remoteAuthority" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" } result['common.remoteAuthority'] = cleanRemoteAuthority(remoteAuthority); + // __GDPR__COMMON__ "common.sandboxed" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" } + result['common.sandboxed'] = process.sandboxed ? '1' : '0'; return result; } From 9fbaa1da25b726819b3f80760e9c032b4e7ed871 Mon Sep 17 00:00:00 2001 From: Benjamin Pasero Date: Fri, 5 Aug 2022 08:44:40 +0200 Subject: [PATCH 2/2] add todo --- .../telemetry/electron-sandbox/workbenchCommonProperties.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/services/telemetry/electron-sandbox/workbenchCommonProperties.ts b/src/vs/workbench/services/telemetry/electron-sandbox/workbenchCommonProperties.ts index 67aac3de104df..d04876a17b7e3 100644 --- a/src/vs/workbench/services/telemetry/electron-sandbox/workbenchCommonProperties.ts +++ b/src/vs/workbench/services/telemetry/electron-sandbox/workbenchCommonProperties.ts @@ -39,7 +39,7 @@ export async function resolveWorkbenchCommonProperties( // __GDPR__COMMON__ "common.remoteAuthority" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth" } result['common.remoteAuthority'] = cleanRemoteAuthority(remoteAuthority); // __GDPR__COMMON__ "common.sandboxed" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" } - result['common.sandboxed'] = process.sandboxed ? '1' : '0'; + result['common.sandboxed'] = process.sandboxed ? '1' : '0'; // TODO@bpasero remove this property when sandbox is on return result; }