From 1617c8b1427f91fc1ba3d92b8678f36689e9918b Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Tue, 18 Oct 2022 08:57:10 -0700 Subject: [PATCH] Dispose of rendered markdown properly --- src/vs/workbench/contrib/scm/browser/scmViewPane.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/contrib/scm/browser/scmViewPane.ts b/src/vs/workbench/contrib/scm/browser/scmViewPane.ts index 18f6ca798669d..76c52d1af59c1 100644 --- a/src/vs/workbench/contrib/scm/browser/scmViewPane.ts +++ b/src/vs/workbench/contrib/scm/browser/scmViewPane.ts @@ -2132,7 +2132,8 @@ class SCMInputWidget { this.contextViewService.hideContextView(); })); - const { element: mdElement } = this.instantiationService.createInstance(MarkdownRenderer, {}).render(message, { + const renderer = disposables.add(this.instantiationService.createInstance(MarkdownRenderer, {})); + const renderedMarkdown = renderer.render(message, { actionHandler: { callback: (content) => { this.openerService.open(content, { allowCommands: typeof message !== 'string' && message.isTrusted }); @@ -2141,7 +2142,8 @@ class SCMInputWidget { disposables: disposables }, }); - element.appendChild(mdElement); + disposables.add(renderedMarkdown); + element.appendChild(renderedMarkdown.element); } const actionsContainer = append(validationContainer, $('.scm-editor-validation-actions')); const actionbar = new ActionBar(actionsContainer);