diff --git a/src/vs/editor/contrib/suggest/test/browser/suggestInlineCompletions.test.ts b/src/vs/editor/contrib/suggest/test/browser/suggestInlineCompletions.test.ts index 5fafaa7cee4de..55f00dce232dd 100644 --- a/src/vs/editor/contrib/suggest/test/browser/suggestInlineCompletions.test.ts +++ b/src/vs/editor/contrib/suggest/test/browser/suggestInlineCompletions.test.ts @@ -4,22 +4,21 @@ *--------------------------------------------------------------------------------------------*/ import * as assert from 'assert'; +import { CancellationToken } from 'vs/base/common/cancellation'; import { DisposableStore } from 'vs/base/common/lifecycle'; import { URI } from 'vs/base/common/uri'; +import { mock } from 'vs/base/test/common/mock'; import { Position } from 'vs/editor/common/core/position'; +import { Range } from 'vs/editor/common/core/range'; import { CompletionContext, CompletionItem, CompletionItemKind, CompletionItemProvider, CompletionList, InlineCompletionTriggerKind, ProviderResult } from 'vs/editor/common/languages'; -import { createTextModel } from 'vs/editor/test/common/testTextModel'; +import { ITextModel } from 'vs/editor/common/model'; +import { TextModel } from 'vs/editor/common/model/textModel'; +import { ILanguageFeaturesService } from 'vs/editor/common/services/languageFeatures'; import { SuggestInlineCompletions } from 'vs/editor/contrib/suggest/browser/suggestInlineCompletions'; +import { ISuggestMemoryService } from 'vs/editor/contrib/suggest/browser/suggestMemory'; import { createCodeEditorServices, instantiateTestCodeEditor, ITestCodeEditor } from 'vs/editor/test/browser/testCodeEditor'; -import { EditorOption } from 'vs/editor/common/config/editorOptions'; -import { CancellationToken } from 'vs/base/common/cancellation'; -import { ILanguageFeaturesService } from 'vs/editor/common/services/languageFeatures'; -import { ITextModel } from 'vs/editor/common/model'; -import { Range } from 'vs/editor/common/core/range'; +import { createTextModel } from 'vs/editor/test/common/testTextModel'; import { ServiceCollection } from 'vs/platform/instantiation/common/serviceCollection'; -import { ISuggestMemoryService } from 'vs/editor/contrib/suggest/browser/suggestMemory'; -import { mock } from 'vs/base/test/common/mock'; -import { TextModel } from 'vs/editor/common/model/textModel'; import { TestInstantiationService } from 'vs/platform/instantiation/test/common/instantiationServiceMock'; @@ -73,7 +72,7 @@ suite('Suggest Inline Completions', function () { test('Aggressive inline completions when typing within line #146948', async function () { - const completions: SuggestInlineCompletions = insta.createInstance(SuggestInlineCompletions, (id: EditorOption) => editor.getOption(id)); + const completions: SuggestInlineCompletions = insta.createInstance(SuggestInlineCompletions, (id) => editor.getOption(id)); { // (1,3), end of word -> suggestions diff --git a/src/vs/platform/instantiation/common/instantiationService.ts b/src/vs/platform/instantiation/common/instantiationService.ts index 78c34bc64f224..659430cd332fb 100644 --- a/src/vs/platform/instantiation/common/instantiationService.ts +++ b/src/vs/platform/instantiation/common/instantiationService.ts @@ -72,7 +72,6 @@ export class InstantiationService implements IInstantiationService { } } - createInstance(ctorOrDescriptor: any | SyncDescriptor, ...rest: any[]): any; // Comment out this line to fix type issues createInstance(descriptor: SyncDescriptor0): T; createInstance any, R extends InstanceType>(ctor: Ctor, ...args: GetLeadingNonServiceArgs>): R; createInstance(ctorOrDescriptor: any | SyncDescriptor, ...rest: any[]): any { diff --git a/src/vs/workbench/api/test/browser/mainThreadWorkspace.test.ts b/src/vs/workbench/api/test/browser/mainThreadWorkspace.test.ts index 565c0dc80ae4f..a13928a488a4e 100644 --- a/src/vs/workbench/api/test/browser/mainThreadWorkspace.test.ts +++ b/src/vs/workbench/api/test/browser/mainThreadWorkspace.test.ts @@ -45,7 +45,7 @@ suite('MainThreadWorkspace', () => { } }); - const mtw: MainThreadWorkspace = instantiationService.createInstance(MainThreadWorkspace, SingleProxyRPCProtocol({ $initializeWorkspace: () => { } })); + const mtw = instantiationService.createInstance(MainThreadWorkspace, SingleProxyRPCProtocol({ $initializeWorkspace: () => { } })); return mtw.$startFileSearch('foo', null, null, 10, new CancellationTokenSource().token); }); @@ -67,7 +67,7 @@ suite('MainThreadWorkspace', () => { } }); - const mtw: MainThreadWorkspace = instantiationService.createInstance(MainThreadWorkspace, SingleProxyRPCProtocol({ $initializeWorkspace: () => { } })); + const mtw = instantiationService.createInstance(MainThreadWorkspace, SingleProxyRPCProtocol({ $initializeWorkspace: () => { } })); return mtw.$startFileSearch('', null, null, 10, new CancellationTokenSource().token); }); @@ -88,7 +88,7 @@ suite('MainThreadWorkspace', () => { } }); - const mtw: MainThreadWorkspace = instantiationService.createInstance(MainThreadWorkspace, SingleProxyRPCProtocol({ $initializeWorkspace: () => { } })); + const mtw = instantiationService.createInstance(MainThreadWorkspace, SingleProxyRPCProtocol({ $initializeWorkspace: () => { } })); return mtw.$startFileSearch('', null, false, 10, new CancellationTokenSource().token); }); @@ -102,7 +102,7 @@ suite('MainThreadWorkspace', () => { } }); - const mtw: MainThreadWorkspace = instantiationService.createInstance(MainThreadWorkspace, SingleProxyRPCProtocol({ $initializeWorkspace: () => { } })); + const mtw = instantiationService.createInstance(MainThreadWorkspace, SingleProxyRPCProtocol({ $initializeWorkspace: () => { } })); return mtw.$startFileSearch('', null, 'exclude/**', 10, new CancellationTokenSource().token); }); }); diff --git a/src/vs/workbench/contrib/tasks/test/browser/taskTerminalStatus.test.ts b/src/vs/workbench/contrib/tasks/test/browser/taskTerminalStatus.test.ts index 1aaa685e9c6a9..11239dc5fa2b9 100644 --- a/src/vs/workbench/contrib/tasks/test/browser/taskTerminalStatus.test.ts +++ b/src/vs/workbench/contrib/tasks/test/browser/taskTerminalStatus.test.ts @@ -36,6 +36,11 @@ class TestTerminal implements Partial { } class TestTask extends CommonTask { + + constructor() { + super('test', undefined, undefined, {}, {}, { kind: '', label: '' }); + } + protected getFolderId(): string | undefined { throw new Error('Method not implemented.'); } @@ -67,7 +72,7 @@ suite('Task Terminal Status', () => { audioCueService = new TestAudioCueService(); taskTerminalStatus = new TaskTerminalStatus(taskService as any, audioCueService as any); testTerminal = instantiationService.createInstance(TestTerminal) as any; - testTask = instantiationService.createInstance(TestTask); + testTask = instantiationService.createInstance(TestTask) as unknown as Task; problemCollector = instantiationService.createInstance(TestProblemCollector) as any; }); test('Should add failed status when there is an exit code on task end', async () => {