From 22a736db8e8c9540aba488dd535b9d1bbdc9d7be Mon Sep 17 00:00:00 2001 From: meganrogge Date: Fri, 10 Mar 2023 10:40:15 -0600 Subject: [PATCH 1/2] fix #176797 --- src/vs/workbench/contrib/terminal/browser/terminalInstance.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts index 2c1a9e4179208..d8d77f93bc97a 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts @@ -1006,7 +1006,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance { } // If tab focus mode is on, tab is not passed to the terminal - if (TabFocus.getTabFocusMode(TabFocusContext.Terminal) && event.keyCode === 9) { + if (TabFocus.getTabFocusMode(TabFocusContext.Terminal) && (event.keyCode === 9 || event.key === 'Tab')) { return false; } From 1328eb052e9e05b9dcb4974a8b2407619d7165db Mon Sep 17 00:00:00 2001 From: meganrogge Date: Fri, 10 Mar 2023 17:38:30 -0600 Subject: [PATCH 2/2] simpilfy --- src/vs/workbench/contrib/terminal/browser/terminalInstance.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts index d8d77f93bc97a..decbf736817cb 100644 --- a/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts +++ b/src/vs/workbench/contrib/terminal/browser/terminalInstance.ts @@ -1006,7 +1006,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance { } // If tab focus mode is on, tab is not passed to the terminal - if (TabFocus.getTabFocusMode(TabFocusContext.Terminal) && (event.keyCode === 9 || event.key === 'Tab')) { + if (TabFocus.getTabFocusMode(TabFocusContext.Terminal) && event.key === 'Tab') { return false; }