Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LICENSE.txt #17684

Merged
merged 3 commits into from Jan 12, 2017

Conversation

Projects
None yet
5 participants
@rohmanhm
Copy link
Contributor

commented Dec 21, 2016

This is the correct writing for MIT License.
With this, you will get MIT licenses tab beside contributors tab.

@msftclas

This comment has been minimized.

Copy link

commented Dec 21, 2016

Hi @rohmanhm, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@chrisdias
Copy link
Member

left a comment

@rohmanhm thanks for the PR, i think it is cool to get the License tab to show up in the repo. A couple of comments on the PR... Microsoft policy is to include the "All rights reserved." clause and omit the year. If you make these changes, will the license tab still show up in GitHub?

@rohmanhm

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2017

@chrisdias Done, sorry my bad miss one line, but now it's clear

@chrisdias
Copy link
Member

left a comment

Thanks for the change... also can we remove the copyright year?

"Copyright (c) Microsoft Corporation"

@rohmanhm

This comment has been minimized.

Copy link
Contributor Author

commented Jan 11, 2017

@chrisdias
Copy link
Member

left a comment

Ok, hopefully last change request :).

After checking with our legal folks, can you do a range on the copyright year?

Copyright (c) 2015 - present Microsoft Corporation

This should still be valid and it will show up as a new tab.

@rohmanhm

This comment has been minimized.

Copy link
Contributor Author

commented Jan 12, 2017

Yes, you can. I make a new commit and it's valid MIT License. You can keep going.

@chrisdias
Copy link
Member

left a comment

looks great!

@chrisdias chrisdias merged commit f3d33d6 into microsoft:master Jan 12, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@AnthonyMeaux101

This comment has been minimized.

Copy link

commented Jan 1, 2018

yy

@AnthonyMeaux101

This comment has been minimized.

Copy link

commented Jan 1, 2018

@hazwan90

This comment has been minimized.

Copy link

commented on c17b649 Jul 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.