From 1cc8a07245672dfcefa4157a3503fd4cd8cdc469 Mon Sep 17 00:00:00 2001 From: Alex Ross Date: Mon, 3 Jul 2023 11:05:08 +0200 Subject: [PATCH] A view with id '~remote.helpPanel' is already registered Fixes #186630 --- src/vs/workbench/contrib/remote/browser/remote.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/contrib/remote/browser/remote.ts b/src/vs/workbench/contrib/remote/browser/remote.ts index 41ff99b995c92..c9cd0c348a2cd 100644 --- a/src/vs/workbench/contrib/remote/browser/remote.ts +++ b/src/vs/workbench/contrib/remote/browser/remote.ts @@ -583,6 +583,7 @@ class RemoteViewPaneContainer extends FilterViewPaneContainer implements IViewMo private _onDidChangeHelpInformation = new Emitter(); public onDidChangeHelpInformation: Event = this._onDidChangeHelpInformation.event; private hasSetSwitchForConnection: boolean = false; + private hasRegisteredHelpView: boolean = false; constructor( @IWorkbenchLayoutService layoutService: IWorkbenchLayoutService, @@ -610,10 +611,12 @@ class RemoteViewPaneContainer extends FilterViewPaneContainer implements IViewMo this._onDidChangeHelpInformation.fire(); const viewsRegistry = Registry.as(Extensions.ViewsRegistry); - if (this.helpInformation.length) { + if (this.helpInformation.length && !this.hasRegisteredHelpView) { viewsRegistry.registerViews([this.helpPanelDescriptor], this.viewContainer); - } else { + this.hasRegisteredHelpView = true; + } else if (this.hasRegisteredHelpView) { viewsRegistry.deregisterViews([this.helpPanelDescriptor], this.viewContainer); + this.hasRegisteredHelpView = false; } }); }