Fix shell integration for windows julia #227724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykim1
added
bug
bhavyaus
approved these changes
Sep 5, 2024
Tyriar
approved these changes
Sep 5, 2024
Contributor
Author
|
This triggers _onShellTypeChanged.fire and _onShellNameChanged, but still doesnt seem to enable shell integration features entirely for julia repl in Windows. |
Member
|
Similar to #227809 (comment), I wouldn't spend much time on this until we get the big upcoming change |
Member
|
Also this only classifies the shell type, it's up to the Julia extension to provide all the shell integration sequences. I'm not sure if they do everything currently (eg. command line sequence?) but I know they do some of it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #225083
#224325
Debugging on windows showed we should search for julialauncher.exe rather than julia.exe for windows julia users.
Turns out we should use 'julialauncher.exe' rather than 'julia.exe' - for the executable to fire event.