From 1cbb27e6d5b6d6a3885660c9c12c55039104082f Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Tue, 18 Mar 2025 19:52:40 +0100 Subject: [PATCH] remove unused code --- .../configurationExportHelper.contribution.ts | 26 ---- .../configurationExportHelper.ts | 120 ------------------ src/vs/workbench/workbench.desktop.main.ts | 3 - 3 files changed, 149 deletions(-) delete mode 100644 src/vs/workbench/contrib/configExporter/electron-sandbox/configurationExportHelper.contribution.ts delete mode 100644 src/vs/workbench/contrib/configExporter/electron-sandbox/configurationExportHelper.ts diff --git a/src/vs/workbench/contrib/configExporter/electron-sandbox/configurationExportHelper.contribution.ts b/src/vs/workbench/contrib/configExporter/electron-sandbox/configurationExportHelper.contribution.ts deleted file mode 100644 index 678bf198d599a..0000000000000 --- a/src/vs/workbench/contrib/configExporter/electron-sandbox/configurationExportHelper.contribution.ts +++ /dev/null @@ -1,26 +0,0 @@ -/*--------------------------------------------------------------------------------------------- - * Copyright (c) Microsoft Corporation. All rights reserved. - * Licensed under the MIT License. See License.txt in the project root for license information. - *--------------------------------------------------------------------------------------------*/ - -import { IWorkbenchContribution, IWorkbenchContributionsRegistry, Extensions as WorkbenchExtensions } from '../../../common/contributions.js'; -import { Registry } from '../../../../platform/registry/common/platform.js'; -import { IInstantiationService } from '../../../../platform/instantiation/common/instantiation.js'; -import { LifecyclePhase } from '../../../services/lifecycle/common/lifecycle.js'; -import { INativeWorkbenchEnvironmentService } from '../../../services/environment/electron-sandbox/environmentService.js'; -import { DefaultConfigurationExportHelper } from './configurationExportHelper.js'; - -export class ExtensionPoints implements IWorkbenchContribution { - - constructor( - @IInstantiationService instantiationService: IInstantiationService, - @INativeWorkbenchEnvironmentService environmentService: INativeWorkbenchEnvironmentService - ) { - // Config Exporter - if (environmentService.args['export-default-configuration']) { - instantiationService.createInstance(DefaultConfigurationExportHelper); - } - } -} - -Registry.as(WorkbenchExtensions.Workbench).registerWorkbenchContribution(ExtensionPoints, LifecyclePhase.Restored); diff --git a/src/vs/workbench/contrib/configExporter/electron-sandbox/configurationExportHelper.ts b/src/vs/workbench/contrib/configExporter/electron-sandbox/configurationExportHelper.ts deleted file mode 100644 index ae0bcfcaf80a0..0000000000000 --- a/src/vs/workbench/contrib/configExporter/electron-sandbox/configurationExportHelper.ts +++ /dev/null @@ -1,120 +0,0 @@ -/*--------------------------------------------------------------------------------------------- - * Copyright (c) Microsoft Corporation. All rights reserved. - * Licensed under the MIT License. See License.txt in the project root for license information. - *--------------------------------------------------------------------------------------------*/ - -import { INativeWorkbenchEnvironmentService } from '../../../services/environment/electron-sandbox/environmentService.js'; -import { Registry } from '../../../../platform/registry/common/platform.js'; -import { IConfigurationNode, IConfigurationRegistry, Extensions, IConfigurationPropertySchema } from '../../../../platform/configuration/common/configurationRegistry.js'; -import { IExtensionService } from '../../../services/extensions/common/extensions.js'; -import { ICommandService } from '../../../../platform/commands/common/commands.js'; -import { IFileService } from '../../../../platform/files/common/files.js'; -import { VSBuffer } from '../../../../base/common/buffer.js'; -import { URI } from '../../../../base/common/uri.js'; -import { IProductService } from '../../../../platform/product/common/productService.js'; - -interface IExportedConfigurationNode { - name: string; - description: string; - default: any; - type?: string | string[]; - enum?: any[]; - enumDescriptions?: string[]; -} - -interface IConfigurationExport { - settings: IExportedConfigurationNode[]; - buildTime: number; - commit?: string; - buildNumber?: number; -} - -export class DefaultConfigurationExportHelper { - - constructor( - @INativeWorkbenchEnvironmentService environmentService: INativeWorkbenchEnvironmentService, - @IExtensionService private readonly extensionService: IExtensionService, - @ICommandService private readonly commandService: ICommandService, - @IFileService private readonly fileService: IFileService, - @IProductService private readonly productService: IProductService - ) { - const exportDefaultConfigurationPath = environmentService.args['export-default-configuration']; - if (exportDefaultConfigurationPath) { - this.writeConfigModelAndQuit(URI.file(exportDefaultConfigurationPath)); - } - } - - private async writeConfigModelAndQuit(target: URI): Promise { - try { - await this.extensionService.whenInstalledExtensionsRegistered(); - await this.writeConfigModel(target); - } finally { - this.commandService.executeCommand('workbench.action.quit'); - } - } - - private async writeConfigModel(target: URI): Promise { - const config = this.getConfigModel(); - - const resultString = JSON.stringify(config, undefined, ' '); - await this.fileService.writeFile(target, VSBuffer.fromString(resultString)); - } - - private getConfigModel(): IConfigurationExport { - const configRegistry = Registry.as(Extensions.Configuration); - const configurations = configRegistry.getConfigurations().slice(); - const settings: IExportedConfigurationNode[] = []; - const processedNames = new Set(); - - const processProperty = (name: string, prop: IConfigurationPropertySchema) => { - if (processedNames.has(name)) { - console.warn('Setting is registered twice: ' + name); - return; - } - - processedNames.add(name); - const propDetails: IExportedConfigurationNode = { - name, - description: prop.description || prop.markdownDescription || '', - default: prop.default, - type: prop.type - }; - - if (prop.enum) { - propDetails.enum = prop.enum; - } - - if (prop.enumDescriptions || prop.markdownEnumDescriptions) { - propDetails.enumDescriptions = prop.enumDescriptions || prop.markdownEnumDescriptions; - } - - settings.push(propDetails); - }; - - const processConfig = (config: IConfigurationNode) => { - if (config.properties) { - for (const name in config.properties) { - processProperty(name, config.properties[name]); - } - } - - config.allOf?.forEach(processConfig); - }; - - configurations.forEach(processConfig); - - const excludedProps = configRegistry.getExcludedConfigurationProperties(); - for (const name in excludedProps) { - processProperty(name, excludedProps[name]); - } - - const result: IConfigurationExport = { - settings: settings.sort((a, b) => a.name.localeCompare(b.name)), - buildTime: Date.now(), - commit: this.productService.commit, - buildNumber: this.productService.settingsSearchBuildId - }; - - return result; - } -} diff --git a/src/vs/workbench/workbench.desktop.main.ts b/src/vs/workbench/workbench.desktop.main.ts index a75ca518457a9..801eccfff6221 100644 --- a/src/vs/workbench/workbench.desktop.main.ts +++ b/src/vs/workbench/workbench.desktop.main.ts @@ -126,9 +126,6 @@ import './contrib/issue/electron-sandbox/process.contribution.js'; // Remote import './contrib/remote/electron-sandbox/remote.contribution.js'; -// Configuration Exporter -import './contrib/configExporter/electron-sandbox/configurationExportHelper.contribution.js'; - // Terminal import './contrib/terminal/electron-sandbox/terminal.contribution.js';