fix: missing translations of remote built-in extensions by hyrious · Pull Request #249430 · microsoft/vscode

hyrious (hyrious) · 2025-05-21T08:16:05Z

Kevin Cui (@BlackHole1) noticed that some translations are missing when develop in remote mode. After digging a bit, we found that only built-in extensions' NLS messages are missing. For example, the Source Control view (contributed by the built-in 'Git' extension) and built-in extensions' configurations are in English.

Despite that the remote server will download and install the corresponding language pack extension, it does not pick the language pack up because of 2 problems:

There's no nls.keys.json in the server build, causing clp/{hash}.{lang}/* failed to generate.
When scanning built-in extensions, the UI language was not passed correctly to the backend.

This PR fixes the 2 problems.

Note about problem 1: The original code Promise.all([mkdir, read keys, read messages]) will fail when the keys file is missing, but the mkdir task would succeed and leave an empty folder which prevents it regenerate in the next calling. So I changed the testing logic from the folder to the file in it.

Fixes #250579

hyrious (hyrious) · 2025-05-21T08:17:54Z

@microsoft-github-policy-service agree

Sandeep Somavarapu (sandy081) · 2025-06-03T15:04:56Z

Can you please share more information here - what is the bug? Are there steps to reproduce? Any screenshots would be helpful. Before that please file an issue first with all this information. Thanks

hyrious (hyrious) · 2025-06-04T03:41:59Z

Sandeep Somavarapu (@sandy081) Hi thanks for showing up. I have created an issue linked to this PR: #250579

TylerLeonhardt · 2025-06-11T19:36:05Z

hyrious (@hyrious) how did you test this change, because I just tested it (by building a local build of VS Code) and it sadly does not work (I'm using a pseudolanguage pack since I know only English)

TylerLeonhardt · 2025-06-11T20:41:41Z

Sandeep Somavarapu (@sandy081) your guidance would be nice here. The steps are easy to reproduce:

Install a language pack
Do any Remote connection (like Dev Containers)
Check the source control view for localization

These strings are localized in the manifest so I'm not sure why, when there's a remote, the manifest strings would stick to English.

hyrious (hyrious) · 2025-06-11T23:10:04Z

TylerLeonhardt A little tricky to test because the remote host should also be built by yourself. If you're using the official reh build in the remote host it wouldn't work.

I actually tested it by manually port changes to the code-server. You may have a try:

Find the code server's source code in the remote OS, it should be inside ~/.vscode-server.
Copy the nls.keys.json from your local vscode to the same folder as nls.messages.json in the remote OS.
Delete the clp folder from the remote OS if it was generated before.
Port changes to the server's source code. If you're just lazy, you can hard code a language option in the scan extensions method (see this pr's diff).
Reconnect to it, this means a full restart of the code-server process. The client should have been modified to send correct IPC messages. Note that in this step, you have to make sure the local commit does not change otherwise the server may refuse to connect.

Kevin Cui (BlackHole1) · 2025-06-12T02:10:18Z

Delete the clp folder from the remote OS if it was generated before.

clp location: ~/.vscode-server-insiders/data/clp

TylerLeonhardt · 2025-06-12T19:47:07Z

I built an Insiders build off of this branch and can confirm that this fixes the problem :)

All good

Sandeep Somavarapu (sandy081) · 2025-06-13T14:42:39Z

 				let scanAllExtensionsPromise = this.scanAllExtensionPromise.get(profileLocation);
 				if (!scanAllExtensionsPromise) {
-					scanAllExtensionsPromise = this.extensionsScannerService.scanAllExtensions({}, userScanOptions)
+					scanAllExtensionsPromise = this.extensionsScannerService.scanAllExtensions({ language }, userScanOptions)


Is not this promise should be cached by language?

Oh.. yes. Maybe I will just use ${profileLocation}?${language} for key of the scanAllExtensionPromise map?

Yes, you need to change both scanned extensions promises map

Sandeep Somavarapu (@sandy081) Sorry, just noticed the comment. Code updated.

TylerLeonhardt · 2025-06-14T00:08:12Z

Sandeep Somavarapu (@sandy081) I defer to you for final approval

Sandeep Somavarapu (sandy081) · 2025-06-27T12:02:18Z

TylerLeonhardt Approved from my side. Should we merge?

TylerLeonhardt

🎉

TylerLeonhardt · 2025-06-27T13:38:49Z

hyrious (@hyrious) this fix is going to make a lot of devs happy. Thank you for contributing!

vs-code-engineering Bot added the triage-needed label May 21, 2025

vs-code-engineering Bot assigned Benjamin Christopher Simmonds (benibenj) May 21, 2025

Benjamin Christopher Simmonds (benibenj) assigned Sandeep Somavarapu (sandy081) and unassigned Benjamin Christopher Simmonds (benibenj) May 21, 2025

hyrious (hyrious) mentioned this pull request Jun 4, 2025

Translations for built-in extensions are missing in remote mode #250579

Open

Sandeep Somavarapu (sandy081) self-requested a review June 4, 2025 11:27

Sandeep Somavarapu (sandy081) assigned TylerLeonhardt and unassigned Sandeep Somavarapu (sandy081) Jun 4, 2025

Sandeep Somavarapu (sandy081) removed their request for review June 4, 2025 11:28

fix: missing translations of remote built-in extensions

4a8ba67

TylerLeonhardt force-pushed the patch-2 branch from e6ea8d6 to 4a8ba67 Compare June 11, 2025 17:47

Copilot AI mentioned this pull request Jun 12, 2025

Fix translations for built-in extensions missing in remote mode #251252

Draft

TylerLeonhardt reviewed Jun 12, 2025

View reviewed changes

Comment thread src/vs/base/node/nls.ts

TylerLeonhardt reviewed Jun 12, 2025

View reviewed changes

Comment thread src/vs/platform/extensionManagement/common/extensionManagement.ts

TylerLeonhardt previously approved these changes Jun 12, 2025

View reviewed changes

TylerLeonhardt requested review from Benjamin Pasero (bpasero) and Sandeep Somavarapu (sandy081) June 12, 2025 19:48

vs-code-engineering Bot added this to the June 2025 milestone Jun 12, 2025

Benjamin Pasero (bpasero) requested a review from Dirk Bäumer (dbaeumer) June 13, 2025 10:18

Benjamin Pasero (bpasero) reviewed Jun 13, 2025

View reviewed changes

Comment thread src/vs/base/node/nls.ts Outdated

Benjamin Pasero (bpasero) removed the triage-needed label Jun 13, 2025

refactor: move mkdir closer to write file

fb40f08

hyrious (hyrious) dismissed TylerLeonhardt’s stale review via fb40f08 June 13, 2025 11:03

Dirk Bäumer (dbaeumer) previously requested changes Jun 13, 2025

View reviewed changes

Comment thread src/vs/base/node/nls.ts

Comment thread src/vs/base/node/nls.ts

Comment thread src/vs/base/node/nls.ts

TylerLeonhardt previously approved these changes Jun 13, 2025

View reviewed changes

Sandeep Somavarapu (sandy081) reviewed Jun 13, 2025

View reviewed changes

refactor: cache scan extensions promise by language

d7c3cd9

hyrious (hyrious) dismissed TylerLeonhardt’s stale review via d7c3cd9 June 13, 2025 15:44

roblourens previously approved these changes Jun 13, 2025

View reviewed changes

TylerLeonhardt previously approved these changes Jun 14, 2025

View reviewed changes

refactor: cache both scan extensions promise

22708b9

hyrious (hyrious) dismissed stale reviews from TylerLeonhardt and roblourens via 22708b9 June 17, 2025 12:10

Sandeep Somavarapu (sandy081) approved these changes Jun 27, 2025

View reviewed changes

Alex Ross (alexr00) approved these changes Jun 27, 2025

View reviewed changes

TylerLeonhardt approved these changes Jun 27, 2025

View reviewed changes

TylerLeonhardt enabled auto-merge (squash) June 27, 2025 13:14

TylerLeonhardt merged commit 7dd2343 into microsoft:main Jun 27, 2025

Ladislau Szomoru (lszomoru) pushed a commit that referenced this pull request Jun 30, 2025

fix: missing translations of remote built-in extensions (#249430)

befc48c

KKKayleX mentioned this pull request Jul 11, 2025

Translation missing in the dev containers mode microsoft/vscode-remote-release#10895

Closed

vs-code-engineering Bot locked and limited conversation to collaborators Aug 11, 2025

Uh oh!

Conversation

hyrious (hyrious) commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hyrious (hyrious) commented May 21, 2025

Uh oh!

Sandeep Somavarapu (sandy081) commented Jun 3, 2025

Uh oh!

hyrious (hyrious) commented Jun 4, 2025

Uh oh!

TylerLeonhardt commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TylerLeonhardt commented Jun 11, 2025

Uh oh!

hyrious (hyrious) commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kevin Cui (BlackHole1) commented Jun 12, 2025

Uh oh!

TylerLeonhardt commented Jun 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sandeep Somavarapu (sandy081) Jun 13, 2025

Choose a reason for hiding this comment

Uh oh!

hyrious (hyrious) Jun 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sandeep Somavarapu (sandy081) Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

hyrious (hyrious) Jun 17, 2025

Choose a reason for hiding this comment

Uh oh!

TylerLeonhardt commented Jun 14, 2025

Uh oh!

Sandeep Somavarapu (sandy081) commented Jun 27, 2025

Uh oh!

TylerLeonhardt left a comment

Choose a reason for hiding this comment

Uh oh!

TylerLeonhardt commented Jun 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

hyrious (hyrious) commented May 21, 2025 •

edited

Loading

TylerLeonhardt commented Jun 11, 2025 •

edited

Loading

hyrious (hyrious) commented Jun 11, 2025 •

edited

Loading

hyrious (hyrious) Jun 13, 2025 •

edited

Loading