Skip to content

[cherry-pick] Disable walkthrough if ai features disabled on startup#318397

Merged
cwebster-99 merged 1 commit into
release/1.122from
cherry-pick/318364
May 26, 2026
Merged

[cherry-pick] Disable walkthrough if ai features disabled on startup#318397
cwebster-99 merged 1 commit into
release/1.122from
cherry-pick/318364

Conversation

@vs-code-engineering
Copy link
Copy Markdown
Contributor

Cherry-pick of #318364 from main.

This pull request introduces logic to ensure that AI-focused onboarding and UI elements are only shown to users when AI features are enabled and visible. The changes primarily impact the onboarding experience for new users and the display of the auxiliary bar in empty workspaces.

Key changes:

Onboarding and Welcome Experience:

  • The onboarding flow now checks if AI features are hidden (using chatEntitlementService.sentiment.hidden) and skips AI-focused onboarding for users where AI features are not available or visible.
  • The StartupPageRunnerContribution class now injects the IChatEntitlementService dependency to access AI feature visibility.
  • The IChatEntitlementService import was added to support the above logic.

Auxiliary Bar Visibility:

  • The logic for showing the auxiliary bar to new users in empty workspaces now also checks if AI features are disabled via the chat.disableAIFeatures configuration, and hides the bar if so.

LayoutStateModel.load() runs during early layout initialization — before any WorkbenchPhase. The ChatEntitlementContext (which sets the chatSetupHidden context key from chat.disableAIFeatures) is lazily created inside ChatEntitlementService and won't be resolved yet. So sentiment.hidden would always return false at that point, defeating the guard.

Copilot AI review requested due to automatic review settings May 26, 2026 17:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@vs-code-engineering vs-code-engineering Bot added the cherry-pick-artifact Auto-generated cherry-pick PR label May 26, 2026
@cwebster-99 cwebster-99 enabled auto-merge May 26, 2026 18:14
@cwebster-99 cwebster-99 merged commit 198ace5 into release/1.122 May 26, 2026
25 checks passed
@cwebster-99 cwebster-99 deleted the cherry-pick/318364 branch May 26, 2026 18:46
@vs-code-engineering vs-code-engineering Bot added this to the 1.122.0 milestone May 26, 2026
dileepyavan pushed a commit that referenced this pull request May 27, 2026
[cherry-pick] Disable walkthrough if ai features disabled on startup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-artifact Auto-generated cherry-pick PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants