fix(server): robustly parse OS_ID from /etc/os-release#318787
Open
developers-universe-1 wants to merge 1 commit into
Open
fix(server): robustly parse OS_ID from /etc/os-release#318787developers-universe-1 wants to merge 1 commit into
developers-universe-1 wants to merge 1 commit into
Conversation
…rements-linux.sh The previous grep-based parser failed when ID was quoted, e.g. ID="rocky" on Rocky Linux 8.5, leaving OS_ID empty and causing the script to exit with code 1. Sourcing /etc/os-release in a subshell and echoing $ID handles both quoted and unquoted values correctly. Fixes microsoft#232159
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #232159
The previous grep-based parser failed when
IDwas quoted, e.g.ID=\"rocky\"on Rocky Linux 8.5, leavingOS_IDempty and causingthe script to exit with code 1.
Sourcing
/etc/os-releasein a subshell and echoing$IDhandlesboth quoted and unquoted values correctly. This approach also aligns
with the format specification for
os-releasefiles.