Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use case-insensitive environment vars on Windows #40466

Merged
merged 2 commits into from Dec 22, 2017
Merged

Use case-insensitive environment vars on Windows #40466

merged 2 commits into from Dec 22, 2017

Conversation

heaths
Copy link
Member

@heaths heaths commented Dec 19, 2017

Fixes #4895

@heaths
Copy link
Member Author

heaths commented Dec 19, 2017

FWIW, with and without my changes I couldn't run an E2E test to completion. When launching a task using either the integrated or external terminals, I'd get:

Error processing 'configurationDone' request. Unknown Error: 0x89720010

Still, with my changes I could still verify the change was effective. Without my changes, I'd still get an error using a path like ${env:WINDIR}\System32 that the path \System32 could not be found; however, with my changes, I'd get past that and just get the error above on the development instance.

I set the --extension-dir to my release instance directory to no avail.

Forgot that missing environment variables are replaced with empty string.
@isidorn isidorn added this to the December 2017/January 2018 milestone Dec 19, 2017
@isidorn isidorn merged commit 80b54dc into microsoft:master Dec 22, 2017
@isidorn
Copy link
Contributor

isidorn commented Dec 22, 2017

@heaths this PR was awesome, neatly done, works great, just tried it out.
Thanks a lot 🍻

@heaths heaths deleted the issue4895 branch December 22, 2017 21:49
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tasks.json environment variable expansion case sensitive
2 participants