Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[themes] Add styles to git commit changed, deleted, inserted #4056

Closed
wants to merge 1 commit into from
Closed

[themes] Add styles to git commit changed, deleted, inserted #4056

wants to merge 1 commit into from

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Mar 12, 2016

Fixes #3991

@aeschli @bpasero

The yellow/orange is .warn, red is .error, green is .comment but slightly lightened. I ended up going with markup instead of git-commit as that's what other themes seemed to be using.

image

image

@bpasero bpasero added this to the March 2016 milestone Mar 13, 2016
@bpasero
Copy link
Member

bpasero commented Mar 13, 2016

Very cool! @aeschli since you own the themes I let you decide if we can add this for March, would be nice.

@aeschli
Copy link
Contributor

aeschli commented Mar 14, 2016

This should go in the defaults VS theme -> extensions/theme-defaults/themes/dark_vs.json & extensions/theme-defaults/themes/light_vs.json

@aeschli aeschli added the themes Color theme issues label Mar 14, 2016
@aeschli aeschli changed the title Add styles to git commit changed, deleted, inserted [themes] Add styles to git commit changed, deleted, inserted Mar 14, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Mar 14, 2016

@aeschli weren't we moving away from default themes as they force themes to override the values? For example this would force having to have a regular font style.

@aeschli
Copy link
Contributor

aeschli commented Mar 14, 2016

@Tyriar The default themes are here to stay, but they are now implemented as a real themes and the default css rules (tokens.css) is now basically empty.

@bpasero
Copy link
Member

bpasero commented Mar 15, 2016

Took care of it 4bb904c

@bpasero bpasero closed this Mar 15, 2016
@Tyriar
Copy link
Member Author

Tyriar commented Mar 16, 2016

@aeschli oh cool, so theme devs should no longer run into conflicts with the default themes? Can #2564 be closed then?

@Tyriar
Copy link
Member Author

Tyriar commented Mar 16, 2016

@bpasero 👍

@aeschli
Copy link
Contributor

aeschli commented Mar 17, 2016

Yes, #2564 is now fixed.

@bpasero bpasero deleted the tyriar/gitmode_colors branch March 17, 2016 07:08
@aeschli aeschli added the verified Verification succeeded label Mar 24, 2016
@ashfurrow ashfurrow mentioned this pull request Aug 5, 2016
Open
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@aeschli aeschli

Labels
themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
March 2016
Development

Successfully merging this pull request may close these issues.

[theme] Dark+ and Light+ should support git commit message scopes
4 participants
@Tyriar @bpasero @aeschli @msftclas