Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Skip quick picker when there is only one task to select from #47853
@sylveon: I looked at the PR yesterday and I noticed that the tasks are now resolved outside of the quick pick. I see why this is happening however this results in the fact that the user has no progress feedback as long as the promise is resolved. This might not be so problematic for terminate and restart, however it will be for run since this on first execution might take some seconds. I need to think about what we can do here. Merging this is as is will make users unhappy where task resolving takes some time.
Update 2: @alexr00 Thanks for the response, I investigated this in more detail tonight and realised actually task had run to completion by the time I performed the restart shortcut. If restart occurred before completion the picker was not shown (desired behaviour). Apologies as I should have picked this up before contributing here. My personal preference would be for restart to behave the same before or after task completion but this is not worth a feature request....
Update: @alexr00 would you like me to open a new issue for this comment as I don't think it's really in the right place? I would simply request that task keyboard shortcuts such as
Just hit issue in this area (actually probably more like #51699 but that has been deemed a dup of this).
I expected my
Very surprised to see the picker.... which means the two are inconsistent.
NB: I'm fine and even agree with a single task picker when selecting Run/Restart Tasks from UI, so this issue is a bit different. Maybe I should open a new issue (or would that be seen as a dup)?