New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CJK-aware line wrapping, and basic Kinsoku Shori (禁則処理) to Visual Studio Code #4825
Add CJK-aware line wrapping, and basic Kinsoku Shori (禁則処理) to Visual Studio Code #4825
Conversation
Hi @be5invis, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
@be5invis, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
/cc @dbaeumer |
@Tyriar @alexandrudima Should I escape all non-ASCII symbols in the .ts files? |
…vis-patch-kinsoku-shori
@alexandrudima @dbaeumer |
Looks good! Thank you @be5invis ! ⭐ |
The main idea is adding a forth character class,
BREAK_IDEOGRAPHIC
, which behaves normally like bothBREAK_BEFORE_CLASS
andBREAK_AFTER_CLASS
, unless it is before aBREAK_AFTER_CLASS
character, or after aBREAK_BEFORE_CLASS
character.