Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CJK-aware line wrapping, and basic Kinsoku Shori (禁則処理) to Visual Studio Code #4825

Merged
merged 13 commits into from Apr 8, 2016
Merged

Add CJK-aware line wrapping, and basic Kinsoku Shori (禁則処理) to Visual Studio Code #4825

merged 13 commits into from Apr 8, 2016

Conversation

be5invis
Copy link
Contributor

The main idea is adding a forth character class, BREAK_IDEOGRAPHIC, which behaves normally like both BREAK_BEFORE_CLASS and BREAK_AFTER_CLASS, unless it is before a BREAK_AFTER_CLASS character, or after a BREAK_BEFORE_CLASS character.

@msftclas
Copy link

Hi @be5invis, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@be5invis, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@Tyriar
Copy link
Member

Tyriar commented Mar 31, 2016

/cc @dbaeumer

@be5invis
Copy link
Contributor Author

@Tyriar @alexandrudima Should I escape all non-ASCII symbols in the .ts files?

@be5invis
Copy link
Contributor Author

be5invis commented Apr 2, 2016

@alexandrudima @dbaeumer
Are there anything I did not cover?

@alexdima alexdima merged commit 8eba9f6 into microsoft:master Apr 8, 2016
@alexdima
Copy link
Member

alexdima commented Apr 8, 2016

Looks good! Thank you @be5invis ! ⭐

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants