Update makefile colorize tests according to the latest grammar #61961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aeschli Test cases will pass after updating the makefile grammar from the upstream (https://github.com/fadeevab/make.tmbundle/). Thank you! |
fadeevab
changed the title
|
@fadeevab, thanks for adding the test case! I'll pull in your grammar update and merge this in next week for the November 2018 milestone. |
zoe704
reviewed
Nov 3, 2018
| @@ -342,7 +342,7 @@ | |||
| }, | |||
| { | |||
| "c": "\tg++ main.o factorial.o hello.o -o hello", | |||
| "t": "source.makefile", | |||
| "t": "source.makefile meta.scope.recipe.makefile", | |||
There was a problem hiding this comment.
I can't get what is this empty comment about? The line is passing into recipe meta scope, that is right.
|
@alexr00 You're welcome! |
|
Just for information How it was: Recipe is looking good now: And a few other fixes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #60030, #61475
Recipe as it was:
Recipe is looking good now:
