Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workbench): add preference to disable recently used tasks #61994

Closed

Conversation

@kumarharsh
Copy link
Contributor

kumarharsh commented Oct 28, 2018

Closes #30419

src/vs/base/common/map.ts Outdated Show resolved Hide resolved
src/vs/base/common/map.ts Outdated Show resolved Hide resolved
src/vs/workbench/electron-browser/main.contribution.ts Outdated Show resolved Hide resolved
src/vs/workbench/parts/tasks/electron-browser/task.contribution.ts Outdated Show resolved Hide resolved
@kumarharsh kumarharsh force-pushed the kumarharsh:feat/recent-task-pref branch Nov 14, 2018
@kumarharsh kumarharsh force-pushed the kumarharsh:feat/recent-task-pref branch to c12a39d Nov 14, 2018
@dbaeumer dbaeumer added this to the November 2018 milestone Nov 15, 2018
@dbaeumer

This comment has been minimized.

Copy link
Member

dbaeumer commented Nov 15, 2018

I am very busy the next couple of days. Needs to wait a little. Sorry for that.

@kumarharsh

This comment has been minimized.

Copy link
Contributor Author

kumarharsh commented Nov 15, 2018

Sure, no problem.

@roblourens roblourens removed this from the December/January 2019 milestone Feb 1, 2019
@alexr00 alexr00 added this to the June 2019 milestone May 27, 2019
Copy link
Member

alexr00 left a comment

For the setting name, we must make it task instead of tasks because tasks is already used for the tasks themselves. That needs to be changed in both files. You can test that the setting is ok by using it in the settings UI.
I ran task five, four, three, two, and then one.
Order of tasks in insiders:
image
Order of tasks with this change:
image

@alexr00

This comment has been minimized.

Copy link
Member

alexr00 commented Jun 5, 2019

Also please resolve the merge conflicts!

@alexr00

This comment has been minimized.

Copy link
Member

alexr00 commented Oct 21, 2019

@kumarharsh Thank you for laying the ground-work for this change. The start you made was finished and merged in #82757.

@alexr00 alexr00 closed this Oct 21, 2019
@alexr00 alexr00 modified the milestones: On Deck, October 2019 Oct 21, 2019
@kumarharsh

This comment has been minimized.

Copy link
Contributor Author

kumarharsh commented Oct 22, 2019

Thanks @alexr00 :)

@kumarharsh kumarharsh deleted the kumarharsh:feat/recent-task-pref branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.