Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support editorHoverWidget.foreground #65170

Closed
wants to merge 5 commits into from

Conversation

@simaosilva
Copy link

simaosilva commented Dec 16, 2018

Implemented issue #63039.
After a couple of tests, it seems to be working as intended and now it is possible to customise the hover foreground color in settings.json.

Before:

before

After:

color_pink

color_yellow

color_yellow_editor

Finally, selecting high_contrast theme:

high_contrast_theme

@msftclas

This comment has been minimized.

Copy link

msftclas commented Dec 16, 2018

CLA assistant check
All CLA requirements met.

simaosilva added 2 commits Dec 21, 2018
@@ -250,6 +250,7 @@ export const editorForeground = registerColor('editor.foreground', { light: '#33
*/
export const editorWidgetBackground = registerColor('editorWidget.background', { dark: '#252526', light: '#F3F3F3', hc: '#0C141F' }, nls.localize('editorWidgetBackground', 'Background color of editor widgets, such as find/replace.'));
export const editorWidgetBorder = registerColor('editorWidget.border', { dark: '#454545', light: '#C8C8C8', hc: contrastBorder }, nls.localize('editorWidgetBorder', 'Border color of editor widgets. The color is only used if the widget chooses to have a border and if the color is not overridden by a widget.'));
export const editorWidgetForeground = registerColor('editorWidget.foreground', { dark: '#aaaaaa', light: '#4d4d4d', hc: '#ffbf80' }, nls.localize('editorWidgetForeground', 'Foreground color of editor widgets, such as find/replace'));

This comment has been minimized.

Copy link
@aeschli

aeschli Jan 3, 2019

Contributor

I would not add that color unless it is supported by all widgets

@aeschli aeschli changed the title Foreground fix support editorHoverWidget.foreground Jan 8, 2019
@aeschli aeschli added this to the October 2019 milestone Oct 24, 2019
@aeschli aeschli closed this in 59ffb07 Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.