From 5f45b940faf3bcbcccd477918fd0385cdf27e797 Mon Sep 17 00:00:00 2001 From: Adrian Fernandez Garcia Date: Tue, 18 Dec 2018 19:39:33 -0800 Subject: [PATCH 1/2] Add and fix arrays.test.ts for strickNullChecks --- src/tsconfig.strictNullChecks.json | 1 + src/vs/base/test/common/arrays.test.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/tsconfig.strictNullChecks.json b/src/tsconfig.strictNullChecks.json index 98573ecd3b612..fd6e809421838 100644 --- a/src/tsconfig.strictNullChecks.json +++ b/src/tsconfig.strictNullChecks.json @@ -113,6 +113,7 @@ "./vs/base/test/browser/ui/tree/indexTreeModel.test.ts", "./vs/base/test/browser/ui/tree/objectTree.test.ts", "./vs/base/test/browser/ui/tree/objectTreeModel.test.ts", + "./vs/base/test/common/arrays.test.ts", "./vs/base/test/common/assert.test.ts", "./vs/base/test/common/cache.test.ts", "./vs/base/test/common/cancellation.test.ts", diff --git a/src/vs/base/test/common/arrays.test.ts b/src/vs/base/test/common/arrays.test.ts index dbc2162bc1d9b..2c9d7cdb2b93b 100644 --- a/src/vs/base/test/common/arrays.test.ts +++ b/src/vs/base/test/common/arrays.test.ts @@ -298,7 +298,7 @@ suite('Arrays', () => { }); test('coalesce - inplace', function () { - let a = [null, 1, null, 2, 3]; + let a: Array = [null, 1, null, 2, 3]; arrays.coalesceInPlace(a); assert.equal(a.length, 3); assert.equal(a[0], 1); From b6f4a61509835ba22f2c598276d21898158d1b3c Mon Sep 17 00:00:00 2001 From: Adrian Fernandez Garcia Date: Tue, 18 Dec 2018 19:43:04 -0800 Subject: [PATCH 2/2] Add type to the other array in array.tests.ts --- src/vs/base/test/common/arrays.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vs/base/test/common/arrays.test.ts b/src/vs/base/test/common/arrays.test.ts index 2c9d7cdb2b93b..38a235ea87163 100644 --- a/src/vs/base/test/common/arrays.test.ts +++ b/src/vs/base/test/common/arrays.test.ts @@ -262,7 +262,7 @@ suite('Arrays', () => { } test('coalesce', () => { - let a = arrays.coalesce([null, 1, null, 2, 3]); + let a: Array = arrays.coalesce([null, 1, null, 2, 3]); assert.equal(a.length, 3); assert.equal(a[0], 1); assert.equal(a[1], 2);