From 546419ed7581b899effa4363f31e5bef748ed7ae Mon Sep 17 00:00:00 2001 From: gangachris Date: Thu, 20 Dec 2018 09:33:35 +0300 Subject: [PATCH] enable strict null check --- src/tsconfig.strictNullChecks.json | 1 + src/vs/base/test/common/keyCodes.test.ts | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/tsconfig.strictNullChecks.json b/src/tsconfig.strictNullChecks.json index 6a2a529b032d2..be7465effe178 100644 --- a/src/tsconfig.strictNullChecks.json +++ b/src/tsconfig.strictNullChecks.json @@ -136,6 +136,7 @@ "./vs/base/test/common/json.test.ts", "./vs/base/test/common/jsonEdit.test.ts", "./vs/base/test/common/jsonFormatter.test.ts", + "./vs/base/test/common/keyCodes.test.ts", "./vs/base/test/common/labels.test.ts", "./vs/base/test/common/lifecycle.test.ts", "./vs/base/test/common/linkedList.test.ts", diff --git a/src/vs/base/test/common/keyCodes.test.ts b/src/vs/base/test/common/keyCodes.test.ts index bc746461f941b..1a72d1bda6e94 100644 --- a/src/vs/base/test/common/keyCodes.test.ts +++ b/src/vs/base/test/common/keyCodes.test.ts @@ -9,13 +9,13 @@ import { OperatingSystem } from 'vs/base/common/platform'; suite('keyCodes', () => { - function testBinaryEncoding(expected: Keybinding, k: number, OS: OperatingSystem): void { + function testBinaryEncoding(expected: Keybinding | null, k: number, OS: OperatingSystem): void { assert.deepEqual(createKeybinding(k, OS), expected); } test('MAC binary encoding', () => { - function test(expected: Keybinding, k: number): void { + function test(expected: Keybinding | null, k: number): void { testBinaryEncoding(expected, k, OperatingSystem.Macintosh); } @@ -57,7 +57,7 @@ suite('keyCodes', () => { [OperatingSystem.Linux, OperatingSystem.Windows].forEach((OS) => { - function test(expected: Keybinding, k: number): void { + function test(expected: Keybinding | null, k: number): void { testBinaryEncoding(expected, k, OS); }