Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Screencast] Add border for keys #67641

Merged
merged 4 commits into from Aug 7, 2019

Conversation

@usernamehw
Copy link
Contributor

commented Jan 31, 2019

demo

@bpasero

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

Maybe better show them as we show keybindings in general (keybindingWidget.ts)? Not sure how that would work in such a large size:

image

@usernamehw

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

I don't think it's viable to use the exact same style (adding a class). The sizes are different font-size/box-shadow/border-radius/padding.

This is how it looks now:
demo

It still probably needs splitting for Shift+Alt+; type of keybindings.

usernamehw added 2 commits Jan 31, 2019

@joaomoreno joaomoreno added this to the Backlog milestone Jan 31, 2019

@joaomoreno

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Thanks! 🍻

@joaomoreno joaomoreno modified the milestones: Backlog, July 2019, August 2019 Aug 7, 2019

@joaomoreno joaomoreno merged commit 2ca7f22 into microsoft:master Aug 7, 2019

3 checks passed

Microsoft.vscode Build #20190131.38 succeeded
Details
VS Code #20190131.38 succeeded
Details
license/cla All CLA requirements met.
Details

@usernamehw usernamehw deleted the usernamehw:key_border branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.