Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide screencast overflow #68048

Merged
merged 4 commits into from Aug 7, 2019

Conversation

@flurmbo
Copy link
Contributor

commented Feb 7, 2019

Fixes #67965 by simply changing the keyboardMarker dom element's style to hide any overflow. It might be better to clear the element on overflow so you can still see what's being typed, but this at least fixes the UI ugliness.

Edit: Now I have it truncate off the beginning when it starts overflowing. Looks a little funky sometimes (i.e "Space" becomes "pace" when truncating) but it looks less jarring to me than just clearing the element.

@kieferrm kieferrm requested a review from joaomoreno Feb 7, 2019

@joaomoreno joaomoreno added this to the Backlog milestone Feb 8, 2019

@joaomoreno

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Thanks!

@joaomoreno joaomoreno modified the milestones: Backlog, August 2019 Aug 7, 2019

@joaomoreno joaomoreno merged commit ba1cc46 into microsoft:master Aug 7, 2019

5 checks passed

VS Code Build #20190214.32 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.