Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing a user to change screencast mode overlay position and height/width from settings. #69314

Merged
merged 2 commits into from Aug 7, 2019

Conversation

@mattkwiecien
Copy link
Contributor

commented Feb 24, 2019

  • Added a new category to the workbench settings, Screencast Mode underneath Zen Mode. This gives us a place to put future screencast mode settings as more are requested.

  • Added 4 new settings to the Screencast Mode category, Vertical Position, Horizontal Position, Height, and Width, with default values that match the current hard coded values.

  • Updated developerActions.ts to pull the styles used for this overlay from the settings.

This fixes issue #66676.

@joaomoreno joaomoreno added this to the Backlog milestone Feb 25, 2019

@mattkwiecien

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

@joaomoreno Any chance I could get a reviewer on this PR? Wanted to make sure this PR doesn't slip through the cracks!

@mattkwiecien

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

@mattkwiecien Large backlog: https://github.com/Microsoft/vscode/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc+assignee%3Ajoaomoreno

oh my... haha, no worries just wanted to make sure this didn't split through the crack!

god speed.

@joaomoreno joaomoreno merged commit f54021d into microsoft:master Aug 7, 2019

5 checks passed

VS Code Build #20190224.8 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Details
@joaomoreno

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

I've just kept the vertical offset setting, I don't think we really need the other ones. Thanks! 🍻

@joaomoreno joaomoreno modified the milestones: Backlog, August 2019 Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.