Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new remote option when publishing branch #71434

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@jmbockhorst
Copy link
Contributor

jmbockhorst commented Mar 29, 2019

Added the ability to add a new remote when publishing a branch. Closes #71242. Here is an example of creating a new branch, selecting the publish branch command, and creating a new remote. The branch gets published to that new remote.

publishBranch

I had a few questions about some ways to make the remote experience more consistent:

  • Should the ability to add a remote be an option on the "Push to.." and "Pull from..." menus as well?
    Screenshot (19)

  • Should the remotes on the "Publish branch" command show the remote URL, like the "Push to.." and "Pull from..." menus do?
    Screenshot (20)_LI

@joaomoreno joaomoreno added this to the Backlog milestone Apr 1, 2019
@joaomoreno joaomoreno added the git label Apr 1, 2019
if (choice === addRemote) {
const newRemote = await this.addRemote(repository);

if (newRemote) {

This comment has been minimized.

Copy link
@mgyongyosi

mgyongyosi Jul 30, 2019

I think "if" statement can be inverted.

if (!newRemote) {
    return;
}
     
remote = newRemote;
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Oct 17, 2019

Thanks! 🍻

I've added this to the Push to... command as well, since it was pretty straightforward. I've also added the URL to the option description in quick pick.

@joaomoreno joaomoreno merged commit 282c57b into microsoft:master Oct 17, 2019
5 checks passed
5 checks passed
VS Code Build #20190329.1 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Details
@joaomoreno joaomoreno modified the milestones: Backlog, October 2019 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.