Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #68201 - adds qs.* label formatting tokens #71874

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@eamodio
Copy link
Contributor

commented Apr 7, 2019

Addresses #68201

Allows ${qs.*} tokens in the resourceLabelFormatters.formatting.label, where the * is resolved to a property of the querystring json object (assuming it is a json object)

/cc @isidorn

@isidorn isidorn self-assigned this Apr 8, 2019

@isidorn

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

Thanks for your PR.
However this milestone we are not focused on adding new features (more about that in the iteratino plan).
Thus putting this to on-deck for now.

@isidorn isidorn added this to the On Deck milestone Apr 8, 2019

@eamodio

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

Doh -- oh sir, it's only wafer thin 🤣

@eamodio

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

@isidorn Any chance for this soon?

@isidorn

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

@eamodio you are the only user that wants this currently. I understand we could use this to better provide label in the explorer for the GitLens or RemoteHub extension but could you point me to a feature request for those extensions such that I possible get motivated to merge this in.

@eamodio

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

@isidorn I don't have any feature request that cover this (mainly because my uri hacks mostly provide a decent experience). It is more of debt that extensions have to pay in formatting uris in strange ways to get them to display nicely in the UI.

@isidorn

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

Ok, that is good enough. This is nice work, so I would merge it in if we add some tests.
Here's a code pointer for tests https://github.com/Microsoft/vscode/blob/73643c60a644145c6a57b61787efd6a62e153cfa/src/vs/workbench/services/label/test/label.test.ts#L22

@eamodio eamodio force-pushed the eamodio:feature/#68201 branch from 044af77 to f8945bf Jul 23, 2019

@eamodio

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

@isidorn sorry for the long delay on this. I've rebased it with master and added a handful of tests. Let me know what you think. 🤞 this can still make it for July.

@eamodio

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

@isidorn any chance? 😉

@isidorn

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

@eamodio sorry for the slow response, I was on a 3 week vacation.
Thanks for adding tests. Great work! Merging in

@isidorn isidorn merged commit 1d7f8eb into microsoft:master Jul 30, 2019

5 checks passed

VS Code Build #20190723.1 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Details

@isidorn isidorn modified the milestones: On Deck, July 2019 Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.