Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DOM scrollbar in SCM commit message box #72171

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@jmbockhorst
Copy link
Contributor

commented Apr 11, 2019

Converted the SCM commit message box to use the native VS Code scrollbar instead of the default one. Closes #57158.
scroll

@jmbockhorst jmbockhorst force-pushed the jmbockhorst:scmScrollBar branch to a9a0379 Apr 12, 2019

@joaomoreno joaomoreno changed the title Use native scrollbar in SCM commit message box Use DOM scrollbar in SCM commit message box Apr 12, 2019

@joaomoreno joaomoreno added the scm label Apr 12, 2019

@joaomoreno joaomoreno added this to the Backlog milestone Apr 12, 2019

@joaomoreno

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Couple of problems with this:

  • Too much bleeds into SCM world. This should all be self contained in InputBox.
  • The ScrollableElement should be affecting the input element, not the div.
  • Holding down selection with the mouse doesn't auto reveal cursor any more.
  • Scrollbar wasn't updating on some events, e.g. paste.
  • Scrollbar wasn't fading out on mouse out, like other workbench scrollbars.

I've cleaned it all up. Thanks for your contribution! 🍻

@joaomoreno joaomoreno modified the milestones: Backlog, August 2019 Aug 8, 2019

@joaomoreno joaomoreno merged commit a9a0379 into microsoft:master Aug 8, 2019

5 checks passed

VS Code Build #20190412.9 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.