Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow `Git: fetch` command to show password prompt #72615

Merged
merged 1 commit into from Oct 17, 2019

Conversation

@oxirt
Copy link
Contributor

oxirt commented Apr 19, 2019

There was some 2 years old code which was preventing Git: fetch command from displaying a password prompt. I've removed this special treatment. Tested, now Git: fetch is showing password prompt as expected and the operation is also successful.

Fixes #72613

There was some 2 years old code which was preventing `Git: fetch` command from displaying a password prompt. I've removed this special treatment. Tested, now `Git: fetch` is showing password prompt as expected and the operation is also successful.
@octref octref requested a review from joaomoreno Apr 20, 2019
@joaomoreno joaomoreno added the git label May 3, 2019
@joaomoreno joaomoreno added this to the Backlog milestone May 3, 2019
Copy link
Member

joaomoreno left a comment

In the issue, I commented:

We should probably change the check to make sure it is only skipped if the fetch is automatic (vs manually)

We still want to skip auth for automatic background fetch requests.

joaomoreno added a commit that referenced this pull request Oct 17, 2019
related to #72615
@joaomoreno joaomoreno merged commit c0cca64 into microsoft:master Oct 17, 2019
5 checks passed
5 checks passed
VS Code Build #20190419.2 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Oct 17, 2019

I've addressed my own feedback.

Thanks! 🍻

@joaomoreno joaomoreno modified the milestones: Backlog, October 2019 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.