Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSDoc typo: "beginPattern" -> "beginsPattern" #73141

Merged
merged 1 commit into from Jul 5, 2019

Conversation

@justingrant
Copy link
Contributor

commented May 1, 2019

The docs for BackgroundMatcher.activeOnStart have a significant typo: they refer to another property "beginPattern" which doesn't actually exist. The actual name is beginsPattern (with an "s"). This PR fixes this typo.

Fix JSDoc typo: "beginPattern" -> "beginsPattern"
The docs for `BackgroundMatcher.activeOnStart` have a significant typo: they refer to another property "beginPattern" which doesn't actually exist. The actual name is `beginsPattern` (with an "s").  This PR fixes this typo.

@dbaeumer dbaeumer added this to the May 2019 milestone May 6, 2019

@bpasero bpasero modified the milestones: May 2019, June 2019 Jun 7, 2019

@dbaeumer dbaeumer modified the milestones: June 2019, July 2019 Jul 1, 2019

@diguifi

diguifi approved these changes Jul 4, 2019

@dbaeumer dbaeumer merged commit b0006ef into microsoft:master Jul 5, 2019

5 checks passed

VS Code Build #20190501.17 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.