Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-73341 Installing extension from extension page "Install" button keeps the notification baloon in bottom right #74795

Merged
merged 3 commits into from Jul 12, 2019

Conversation

@skprabhanjan
Copy link
Contributor

commented Jun 3, 2019

@sandy081 , Removed the notification bubble as discussed to fix #73341.
Please review this and let me know :)

@kieferrm kieferrm requested a review from sandy081 Jun 3, 2019

@sandy081 sandy081 added this to the May 2019 milestone Jun 3, 2019

@skprabhanjan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2019

@sandy081 , Sorry for that , Did not check that part.
Changed it accordingly :)

@sandy081

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

@skprabhanjan looks like your change has build failures. Can you please fix them.
I guess it is caused because of unused import Severity.

@dmolin

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

@skprabhanjan looks like your change has build failures. Can you please fix them.
I guess it is caused because of unused import Severity.

@sandy081 , It's true on Linux/Mac, but on Windows it seems quite a different error, occurred when installing dependencies:

d:\a\1\s\remote\node_modules\keytar\node_modules\nan\nan.h(24): fatal error C1083: Cannot open include file: 'node_version.h': No such file or directory (compiling source file ..\src\async.cc) [D:\a\1\s\remote\node_modules\keytar\build\keytar.vcxproj]
@sandy081

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

Could be a random error in windows.

@bpasero bpasero modified the milestones: May 2019, June 2019 Jun 7, 2019

@skprabhanjan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

@sandy081 , I have removed the unused import

@skprabhanjan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

@sandy081 , Any update on this PR ?
The build should be good now.

@sandy081

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

Will take a look in next milestone.

@skprabhanjan

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2019

@sandy081 , this should be good to be merged now correct ? ( if the PR has passed your review)

@skprabhanjan

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

@sandy081 , any updates on this ? Sorry

@sandy081 sandy081 merged commit 2e53042 into microsoft:master Jul 12, 2019

3 of 5 checks passed

VS Code Build #20190610.3 had test failures
Details
VS Code (Windows) Windows failed
Details
VS Code (Linux) Linux succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.