Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop event propagation in `onEditSettingClicked` #75967

Merged
merged 1 commit into from Jul 6, 2019

Conversation

@jeanp413
Copy link
Contributor

commented Jun 23, 2019

Fixes #75026 (#75947)

@sandy081 sandy081 self-assigned this Jun 24, 2019

@sandy081 sandy081 self-requested a review Jun 24, 2019

@roblourens roblourens self-assigned this Jul 6, 2019

@roblourens
Copy link
Member

left a comment

I can't repro the issue so I can't test the fix, but this looks ok to me and does not seem to break anything

@roblourens roblourens merged commit 10302f5 into microsoft:master Jul 6, 2019

5 checks passed

VS Code Build #20190623.5 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.

@roblourens roblourens added this to the July 2019 milestone Jul 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.