Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify dotnet build templates #76318

Merged
merged 3 commits into from Jul 29, 2019

Conversation

@akshita31
Copy link
Contributor

commented Jun 28, 2019

  1. The build should produce fullpaths because that is needed by the msCompile problem matcher.
  2. The build should not produce summary as then in the "Problems" pane, the errors are duplicated.

Fixes: OmniSharp/omnisharp-vscode#1198, OmniSharp/omnisharp-vscode#1197

@akshita31

This comment has been minimized.

Copy link
Contributor Author

commented Jun 28, 2019

@alexr00 alexr00 added this to the July 2019 milestone Jul 1, 2019

@akshita31 akshita31 referenced this pull request Jul 1, 2019
@rchande

rchande approved these changes Jul 1, 2019

@rchande

This comment has been minimized.

Copy link

commented Jul 1, 2019

Doesn't seem like the test failures are related to the change...

@alexr00
Copy link
Member

left a comment

The full paths change looks good, but I'm not so sure about the NoSummary change. People are pretty used to seeing an error summary at the end. I am not a heavy user of dotnet though. Can you add an additional comment about what that argument does so that users of the template can see why the summary is missing?

@akshita31

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

@alexr00 Since the errors are repeated in the summary, in the problems pane there are duplicate errors:

image

If we disable the summary then there is only one error. Does that sound reasonable ? Is there any other way we can reduce the duplicate errors coming up in the problems pane ?

@akshita31

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

@alexr00 Any updates here ?

@alexr00
Copy link
Member

left a comment

Sorry about the delay, I was on vacation.
Looks good thank you!

@alexr00 alexr00 merged commit 0a21b40 into microsoft:master Jul 29, 2019

5 checks passed

VS Code Build #20190715.68 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.

@akshita31 akshita31 deleted the akshita31:modify_build_templates_for_dotnet branch Aug 2, 2019

@Arunsanthoshh

This comment has been minimized.

Copy link

commented Aug 14, 2019

Hi @akshita31 ,

I couldn`t use dotnet build in VS 1.37.0 version. I shows the following issue.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.