Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix-72650 Shell paths should be validated before launched to prevent ambiguous errors - $Path check #76349

Merged
merged 3 commits into from Jun 29, 2019

Conversation

@skprabhanjan
Copy link
Contributor

commented Jun 29, 2019

@Tyriar , Here is the new PR to #72650.
Please let me know I can do something here and fix anything ( Maybe for the async part which I am anyways trying once ).
Thanks again :)

@Tyriar

This comment has been minimized.

Copy link
Member

commented Jun 29, 2019

The failure to push thing was actually related to git lfs misbehaving in my setup.

@Tyriar Tyriar added this to the July 2019 milestone Jun 29, 2019

@Tyriar

Tyriar approved these changes Jun 29, 2019

Copy link
Member

left a comment

Made some changes to make it all async again and base it on the tasks function (which tasks may depend on later #76351)

@Tyriar Tyriar merged commit 724b1c6 into microsoft:master Jun 29, 2019

5 checks passed

VS Code Build #20190629.18 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Details
@skprabhanjan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2019

@Tyriar , Thanks a lot for the changes and merge :)
Will make sure to use better async approach from next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.