Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure to encode % more aggresive #76615

wants to merge 2 commits into from


None yet
2 participants
Copy link

commented Jul 4, 2019

This PR is for #76506

@jrieken jrieken self-assigned this Jul 4, 2019

@jrieken jrieken added this to the June 2019 Recovery milestone Jul 4, 2019

@@ -448,7 +448,7 @@ suite('URI', () => {

uri = URI.file('/test with %25/c#code');
assert.equal(uri.path, '/test with %25/c#code');
assert.equal(uri.toString(), 'file:///test%20with%20%25/c%23code');
assert.equal(uri.toString(), 'file:///test%20with%20%2525/c%23code');

This comment was marked as resolved.

Copy link

Xmader Jul 4, 2019

assert.equal(value.toString(), 'file:///c%3A/test%20with%20%25/path');
assert.equal(value.toString(), 'file:///c%3A/test%20with%20%25/c%23code');
are also affected by the changes.
Please modify these lines to pass the unit tests.

@jrieken jrieken requested a review from aeschli Jul 5, 2019


This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2019

we will rollback to the May version of the uri

@jrieken jrieken closed this Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.