Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quick terminal splitting for tasks #76684

Merged
merged 1 commit into from Jul 5, 2019

Conversation

Projects
None yet
2 participants
@alexr00
Copy link
Member

commented Jul 5, 2019

Looks like there is a timing issue with trying to split terminals too quickly. By the time that tasks gets the terminal instance back, it isn't guaranteed to have a height and width yet, which means it can't be split. Waiting until there is a title on the terminal is long enough for it to have dimensions.
Part of #76611

@alexr00 alexr00 added this to the June 2019 Recovery milestone Jul 5, 2019

@alexr00 alexr00 self-assigned this Jul 5, 2019

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

One minor suggestion is to add onReady() support for the terminal instead of using wait for title

@dbaeumer
Copy link
Member

left a comment

LGTM

@alexr00 alexr00 merged commit 9a2d5b7 into release/1.36 Jul 5, 2019

6 checks passed

VS Code Build #20190705.27 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
VS Code Distro Sync & Merge Check #20190705.18 succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.