Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use right arch in distro dependencies #76843

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Projects
None yet
2 participants
@joaomoreno
Copy link
Member

commented Jul 8, 2019

Candidate fix for #76740

We need to set the npm_config_arch env to the right architecture on Windows builds, since that build template is used for both x64 and ia32. This broke recently, since the installDistroDependencies script was split into another build task than yarn install, which sets the correct env. We should set the npm_config_arch env in that new task as well.

@joaomoreno joaomoreno added this to the June 2019 Recovery milestone Jul 8, 2019

@joaomoreno joaomoreno requested a review from jrieken Jul 8, 2019

@joaomoreno joaomoreno self-assigned this Jul 8, 2019

@jrieken

jrieken approved these changes Jul 8, 2019

@joaomoreno joaomoreno merged commit e3c3ba5 into release/1.36 Jul 8, 2019

6 checks passed

VS Code Build #20190708.17 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
VS Code Distro Sync & Merge Check #20190708.10 succeeded
Details
license/cla All CLA requirements met.

@joaomoreno joaomoreno deleted the joao/release/1.36/76740 branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.