Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lifecycle for code actions that are updated while the code action menu is already showing #76917

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Projects
None yet
2 participants
@mjbvz
Copy link
Contributor

commented Jul 8, 2019

Fixes #76851

In the following case

  1. Code action list is shown
  2. We then update the code actions in the background (possibly because extensions took a little while to compute them)
  3. The user accepts a code action

At step 2, we release the previous code action list which causes all of its actions to be gabage collected

Fix
Move lifecycle management of the code actions into the two consumers. Will look into make the code safer with a follow up fix

Fix lifecycle for code actions that are updated while the code action…
… menu is already showing

Fixes #76851

In the following case

1. Code action list is shown
1. We then update the code actions in the background (possibly because extensions took a little while to compute them)
1. The user accepts a code action

At step 2, we release the previous code action list which causes all of its actions to be gabage collected

**Fix**
Move lifecycle management of the code actions into the two consumers. Will look into make the code safer with a follow up fix

@mjbvz mjbvz added this to the June 2019 Recovery milestone Jul 8, 2019

@mjbvz mjbvz self-assigned this Jul 8, 2019

@octref

octref approved these changes Jul 8, 2019

@octref octref merged commit 2213894 into microsoft:release/1.36 Jul 8, 2019

3 of 5 checks passed

VS Code Build #20190708.79 failed
Details
VS Code (Windows) Windows failed
Details
VS Code (Linux) Linux succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.