Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sash): dragging being difficult with iframe-containing extensions #77121

Merged
merged 2 commits into from Jul 12, 2019

Conversation

@connor4312
Copy link
Member

commented Jul 10, 2019

It appears that (running querySelector, getElementByTagName) the
contents of electron's <webviews>, which contain the iframe, are
inaccessible. We were already disabling pointer events on iframes, this PR
makes sure we do so on webviews as well.

Kapture 2019-07-10 at 10 32 10

Fixes #76866

fix(sash): dragging being difficult with iframe-containing extensions
It appears that (running querySelector, getElementByTagName) that the
contents of electron's `<webviews>`, which contain the iframe, are
inaccessible. We were already disabling pointer events on iframes, this PR
makes sure we do so on webviews as well.
@joaomoreno

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

@mjbvz Maybe the fix is that simple. Wanna give this a try, removing your mouse event forwarding? Also see #77152

@connor4312

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

@joaomoreno it looks like @mjbvz's fix is identical to this one, but has some additional code cleanup elsewhere.

@@ -280,7 +286,6 @@ export class Sash extends Disposable {

dispose(disposables);

const iframes = getElementsByTagName('iframe');

This comment has been minimized.

Copy link
@connor4312

connor4312 Jul 11, 2019

Author Member

I removed this so that we use the same set of frames we selected previously (iframes was shadowed here). No need to select them twice--even if there's new iframes/webviews that appeared whilst dragging, we don't need to 'reset' their pointer events since we didn't touch them before.

@mjbvz mjbvz merged commit 8536df9 into microsoft:master Jul 12, 2019

5 checks passed

VS Code Build #20190711.87 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
@mjbvz

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

Thanks. The fix looks reasonable to me. It will be in the next 1.37 insiders build for testing

@mjbvz mjbvz added this to the July 2019 milestone Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.