Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear disposables in the clearInput method on Disposables #77479

Merged
merged 16 commits into from Jul 17, 2019

Conversation

@pi1024e
Copy link
Contributor

commented Jul 16, 2019

I saw this pull request on PR #75874, but not only has it not been merged, it has plenty of unresolved conflicts so I made a PR rebased on the most current version of the repository.

This Fixes #75532, and it clears the disposables during clearing text. The code has been refactored to allow this, as to prevent any issues or side effects from arising.

I hope this is useful!

@mjbvz mjbvz self-assigned this Jul 16, 2019

@pi1024e

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

Fixed. Reverted unnecessary changes.

@pi1024e

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

Rebased the PR on the CURRENT master branch of the official Microsoft vscode repository

src/vs/base/common/uri.ts Outdated Show resolved Hide resolved
@pi1024e

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2019

Everything should be good to go!

@mjbvz mjbvz added this to the July 2019 milestone Jul 17, 2019

@mjbvz mjbvz merged commit 7dbaf1a into microsoft:master Jul 17, 2019

5 checks passed

VS Code Build #20190717.32 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.