Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Update VS Code from Command Palette #77515

Merged
merged 2 commits into from Oct 25, 2019

Conversation

@DiamondYuan
Copy link
Contributor

DiamondYuan commented Jul 17, 2019

close #77184

@msftclas

This comment has been minimized.

Copy link

msftclas commented Jul 17, 2019

CLA assistant check
All CLA requirements met.

@DiamondYuan

This comment has been minimized.

Copy link
Contributor Author

DiamondYuan commented Jul 18, 2019

@joaomoreno

CI broken,How to fix it ?

src/vs/workbench/contrib/update/common/update.ts:6:48:Unexternalized string found: "update.showCurrentReleaseNotes"
src/vs/workbench/contrib/update/common/update.ts:7:45:Unexternalized string found: "update.checkForVSCodeUpdate"
Copy link
Member

joaomoreno left a comment

Please merge both classes, there's no need for an abstract class here.

src/vs/workbench/contrib/update/common/update.ts Outdated Show resolved Hide resolved
@DiamondYuan DiamondYuan force-pushed the webclipper:feat/checkUpdate branch Jul 18, 2019
@DiamondYuan

This comment has been minimized.

Copy link
Contributor Author

DiamondYuan commented Jul 18, 2019

Please merge both classes, there's no need for an abstract class here.

Ci Broken,Time out

@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Jul 18, 2019

CI is not broken. You are using double quotes instead of double quotes. CI is telling you exactly that.

@DiamondYuan

This comment has been minimized.

Copy link
Contributor Author

DiamondYuan commented Jul 18, 2019

CI is not broken. You are using double quotes instead of double quotes. CI is telling you exactly that.

image

https://dev.azure.com/vscode/VSCode/_build/results?buildId=23300

Last CI broken was due to timeout. I have solved the error.

@joaomoreno joaomoreno added this to the Backlog milestone Jul 18, 2019
@DiamondYuan

This comment has been minimized.

Copy link
Contributor Author

DiamondYuan commented Jul 23, 2019

cc @joaomoreno when will whit PR be merged ?

@DiamondYuan DiamondYuan force-pushed the webclipper:feat/checkUpdate branch Jul 24, 2019
@DiamondYuan DiamondYuan force-pushed the webclipper:feat/checkUpdate branch to 264ec27 Jul 24, 2019
@joaomoreno joaomoreno merged commit 264ec27 into microsoft:master Oct 25, 2019
5 checks passed
5 checks passed
VS Code Build #20190724.17 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Details
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Oct 25, 2019

Thanks! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.