Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sql language syntax #77601

Merged

Conversation

@anthonydresser
Copy link
Member

anthonydresser commented Jul 18, 2019

Updates the sql language syntax to what we currently use in our tools on the sql team

@alexr00 alexr00 added this to the August 2019 milestone Jul 29, 2019
@alexr00 alexr00 modified the milestones: September 2019, October 2019 Oct 7, 2019
@alexr00

This comment has been minimized.

Copy link
Member

alexr00 commented Oct 7, 2019

@anthonydresser I'm sorry this slipped my notice!
We get our SQL grammar from https://github.com/Microsoft/vscode-mssql so any changes to sql.tmlanguage.json should be made there first.

Your changes to the language-configuration seem reasonable though, so I'm happy to take those!

@alexr00

This comment has been minimized.

Copy link
Member

alexr00 commented Oct 7, 2019

I'll merge in the language-configuration changes now, and we can figure out how to continue with the grammar changes.

@alexr00 alexr00 force-pushed the anthonydresser:feat/updatesqllanguagesyntax branch from ca418b5 to 6e4fc70 Oct 7, 2019
@alexr00 alexr00 merged commit 28402eb into microsoft:master Oct 7, 2019
2 checks passed
2 checks passed
VS Code #20191007.15 succeeded
Details
license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.