Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "whiteSpace" typo: Parameter name and word is one command word spelled "whitespace". #77758

Merged
merged 26 commits into from Jul 24, 2019

Conversation

@pi1024e
Copy link
Contributor

commented Jul 22, 2019

When browsing the vscode source, I noticed there is a misspelling of the word "whitespace", where the variable/property names were "whiteSpace". I noticed that this could have huge consequences, as the property "renderWhitespace" has no capital s, but in the commonEditorConfig, the property name has a capital s. As a result, I replaced "whiteSpace" variable names to "whitespace".

I did this by searching and replacing all instances of "whiteSpace" and "WhiteSpace" to "whitespace" and "Whitespace" respectively. There was one comment that was an incomplete sentence regarding one of the whitespace functions, so I fixed that as well.

Finally, I was able to reduce the code in PathCompletion regarding whitespace handling. The code has the same behavior, and passed the automated and smoke tests.

I hope this proves useful in the long run!

@pi1024e

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

I undid the unnecessary style changes. Thank you.

@pi1024e

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

Are these changes appropriate, or are there any changes I need to fix?

@mjbvz

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

It looks like there are still refactoring changes in rangeMap.ts and glob.ts and listWidget.ts. Again, this change should only have the spelling fixes.

pi1024e added some commits Jul 24, 2019

@pi1024e

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

Made changes!

@mjbvz mjbvz added this to the July 2019 milestone Jul 24, 2019

@mjbvz mjbvz merged commit 7674039 into microsoft:master Jul 24, 2019

5 checks passed

VS Code Build #20190724.38 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Details
@mjbvz

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

Thanks!

@Tyriar

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

@pi1024e the way you're working is spamming links in some of our issues, for example in #78168:

image

It looks like you're co-authoring commits when you're syncing or something, please avoid this as it causes a lot of noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.