Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a newer version of @types/node in the build folder to match all other folders #77784

Merged
merged 2 commits into from Jul 23, 2019

Conversation

@weswigham
Copy link
Member

commented Jul 22, 2019

The old node 8 definitions will throw on TS 3.6 with

node_modules/@types/node/index.d.ts(66,11): error TS2300: Duplicate identifier 'IteratorResult'.
node_modules/typescript/lib/lib.es2015.iterable.d.ts(41,6): error TS2300: Duplicate identifier 'IteratorResult'.

every other package file was already using a caret-version referencing node 10, so I just adjusted the build folder to do the same (a newer version of the node 8 types could also be used, but given that this was the odd package file out, I assume it was just an oversight during some upgrade process).

@mjbvz mjbvz added this to the July 2019 milestone Jul 22, 2019

@mjbvz

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

Thanks @weswigham. Can you please just run yarn in the build directory too to update the lock file. That's what caused the build to fail

@weswigham

This comment has been minimized.

Copy link
Member Author

commented Jul 22, 2019

@mjbvz done - I had to bump the applicationinsights version in the build folder as well, since apparently AI 1.0.6 used a type from the node .d.ts that no longer exists (while AI 1.0.8, which was already in use in the rest of the codebase is fine).

@mjbvz mjbvz requested a review from joaomoreno Jul 22, 2019

@mjbvz

mjbvz approved these changes Jul 22, 2019

@joaomoreno
Copy link
Member

left a comment

This LGTM but @jrieken might want to check the monaco-editor compile task.

@jrieken

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

want to check the monaco-editor compile task.

Green build means that it's happy

@jrieken jrieken removed their request for review Jul 23, 2019

@mjbvz mjbvz merged commit d827a3a into microsoft:master Jul 23, 2019

5 checks passed

VS Code Build #20190722.77 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Details
@mjbvz

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

Thanks @weswigham!

@weswigham weswigham deleted the weswigham:make-build-node-types-synced branch Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.