Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip]feat: support list.focusParent command #77848

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@DiamondYuan
Copy link
Contributor

commented Jul 24, 2019

close #77343

cc @joaomoreno

I am not very clear about how primary should be written.

i use KeyCode.Shift | KeyCode.LeftArrow but not work.

@DiamondYuan DiamondYuan force-pushed the webclipper:feat/focusParent branch to 9800baa Jul 24, 2019

@DiamondYuan DiamondYuan changed the title feat: support list.focusParent command [wip]feat: support list.focusParent command Jul 24, 2019

@joaomoreno joaomoreno added this to the Backlog milestone Jul 25, 2019

@joaomoreno joaomoreno added the tree label Jul 25, 2019

@joaomoreno

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

It should be KeyMod.Shift. But I've simply removed the default keybinding, we don't really need one.

Thanks! 🍻

@joaomoreno joaomoreno modified the milestones: Backlog, August 2019 Aug 9, 2019

@joaomoreno joaomoreno merged commit 9800baa into microsoft:master Aug 9, 2019

3 of 5 checks passed

VS Code Build #20190724.19 failed
Details
VS Code (Windows) Windows was canceled
Details
VS Code (Linux) Linux succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.