Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace: honor preserveCase when replacing all #78003

Merged

Conversation

@vlmphipps
Copy link

commented Jul 26, 2019

Previously preserveCase worked when replacing single matches, but not when replacing all matches.

#9798

@msftclas

This comment has been minimized.

Copy link

commented Jul 26, 2019

CLA assistant check
All CLA requirements met.

@rebornix

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

@vlmphipps thanks for the contribution, could you please sign the CLA then we can merge the PR ?

@rebornix rebornix self-assigned this Jul 26, 2019

@vlmphipps

This comment has been minimized.

Copy link
Author

commented Jul 26, 2019

Will do, consulting with legal

@vlmphipps

This comment has been minimized.

Copy link
Author

commented Jul 26, 2019

All set

@rebornix rebornix merged commit 49cae20 into microsoft:master Jul 29, 2019

5 checks passed

VS Code Build #20190726.32 succeeded
Details
VS Code (Linux) Linux succeeded
Details
VS Code (Windows) Windows succeeded
Details
VS Code (macOS) macOS succeeded
Details
license/cla All CLA requirements met.
Details

@vlmphipps vlmphipps deleted the vlmphipps:vphipps-preservecase-replaceall branch Jul 30, 2019

@roblourens roblourens added this to the July 2019 milestone Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.