Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep the two "Copy Path" behavior consistent #79294

Merged
merged 1 commit into from Aug 18, 2019

Conversation

@LeuisKen
Copy link
Contributor

commented Aug 16, 2019

When using remote, this "Copy Path" function of SearchAction will keep the remote prefix while the FileCommand will not.

SearchAction "Copy Path":

FileCommand "Copy Path":

fix: keep the two "Copy Path" behavior consistent
When using remote, this "Copy Path" function of SearchAction will keep the remote prefix while the FileCommand will not.

Change-Id: Ide00d2da5a695d0adbe87622643c7a600dd46432
@isidorn

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

Search Copy Path should just copy the path part of the URI component.
Since most of the changes are in the search area forwarding to @roblourens

@MJ-Mohith
Copy link

left a comment

It would be great if you show the copied path and its difference in both the case, it will give us a clear picture.

@roblourens

This comment has been minimized.

Copy link
Member

commented Aug 18, 2019

This is the bug and the new behavior:
image

@roblourens roblourens merged commit 4fa0890 into microsoft:master Aug 18, 2019

2 checks passed

VS Code #20190816.17 succeeded
Details
license/cla All CLA requirements met.
Details

@roblourens roblourens added this to the August 2019 milestone Aug 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.