Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow goToLine to work backwards #79348

Merged
merged 2 commits into from Aug 26, 2019

Conversation

@SneakyFish5
Copy link
Contributor

commented Aug 17, 2019

Fixes #79286

Are there any docs that would need editing too with a change like this?

@bpasero bpasero added this to the On Deck milestone Aug 20, 2019

@bpasero bpasero modified the milestones: On Deck, September 2019 Aug 22, 2019

@bpasero bpasero self-requested a review Aug 25, 2019

@bpasero
Copy link
Member

left a comment

This needs to still check for the line being valid though:

image

@SneakyFish5 SneakyFish5 force-pushed the SneakyFish5:gotoline-negative branch to 33e53ee Aug 25, 2019

@SneakyFish5

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2019

Good catch! Just pushed a fix for it.

@bpasero bpasero merged commit c157da1 into microsoft:master Aug 26, 2019

@bpasero

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

Thanks 👍

@bpasero bpasero modified the milestones: September 2019, August 2019 Aug 26, 2019

@SneakyFish5

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

Thanks for merging, just wanted to reiterate my original question about the docs. Would there be anything I need to change or no?

@SneakyFish5 SneakyFish5 deleted the SneakyFish5:gotoline-negative branch Aug 26, 2019

@bpasero

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

Thanks for asking, I actually think we do not even document this feature on https://code.visualstudio.com/docs, but if you can find it we can update it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.